Conversation
FedericoEsparza
left a comment
There was a problem hiding this comment.
@mattwr18 Shall I merge this?
|
oh hey @FedericoEsparza sorry, I meant to reach out to you and see if you wouldn't mind merging some This is ready to be merged, I believe, we have left the c9 code just in case we want to go back to using phantomjs |
FedericoEsparza
left a comment
There was a problem hiding this comment.
I don't know that I can merge this.
It had a lot of issues on my computer (running phx 1.4)
I pushed up a branch PR-review-branch-16-
I made several error-driven updates in pushing to simply run mix test with chromedriver. (i.e. chromedriver & mix test && pkill chromedriver)
I didn't have enough time to get it to work.
I got as far as a BEAM (OTP compiled version) issue:

You're welcome to pull down the branch and troubleshoot.
Then you can use the above link to put in a PR to the original PR.
OR if it's working on your machines, feel free to just merge the original PR
Sorry for not reviewing this sooner.
|
sorry for the late reply, this highlights the issue with getting it working in one environment and not properly testing it in others... really appreciate your attention to this @FedericoEsparza |
- Update hound in deps to use https instead of ssh for github - delete order.tests
|
it's working for @aonomike on Mac, we haven't tried it with Phoneix 1.4 because we are on 1.3. We can certainly merge this, if you prefer, don't want cause extra work for you, but we are also not in a huge rush, maybe we'll go forward in the book just next week. @aonomike will put in a |
Co-authored-by: Mike Aono <aonomike@gmail.com>
9309dd5 to
7a658a2
Compare
- issue with jdk version preinstalled? Co-authored-by: Mike Aono <aonomike@gmail.com>
7a658a2 to
57a433c
Compare
- 11 not supported by trusty Co-authored-by: Mike Aono <aonomike@gmail.com>
Co-authored-by: Mike Aono <aonomike@gmail.com>
fixes#16