fix: OpenAI Chat Completions tool calls #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
dot-agi
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the OpenAI chat instrumentation to create dedicated tool-call spans instead of simply recording tool-call attributes.
- Introduces a
_create_tool_spanhelper to start child spans for each tool call - Updates
handle_chat_attributesto invoke the new span helper for non-streaming calls - Modifies the streaming wrapper to import and use
_create_tool_spaninstead of setting tool-call attributes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentops/instrumentation/providers/openai/wrappers/chat.py | Add _create_tool_span, adjust handle_chat_attributes to call it |
| agentops/instrumentation/providers/openai/stream_wrapper.py | Import and use _create_tool_span in stream finalization |
Comments suppressed due to low confidence (1)
agentops/instrumentation/providers/openai/stream_wrapper.py:18
- [nitpick] Importing a private helper function (
_create_tool_span) across modules couples implementation details. Consider promoting it to a public utility or moving it to a shared helper module.
from agentops.instrumentation.providers.openai.wrappers.chat import handle_chat_attributes, _create_tool_span
19a989f to
f564029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
📘 Description
Fix for tool calls in OpenAI Chat Completions API
🧪 Testing
Trust me bro arc 😉