Fix decorator initialization failures - auto-initialize when tracer not ready #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic - Add auto-initialization to decorator factory when tracer is not initialized - Follow same pattern as start_trace() function for consistency - Add proper logging for debugging initialization attempts - Maintain backward compatibility by falling back to unwrapped function on failure - Fixes silent failures of @agent, @tool, @task decorators when SDK not initialized Co-Authored-By: Alex <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
- Fix line length and spacing issues identified by pre-commit checks - Maintain functionality while conforming to code style requirements Co-Authored-By: Alex <[email protected]>
- Test successful auto-initialization when tracer is not initialized - Test graceful handling of initialization failures - Test partial initialization failure scenarios - Provides coverage for the auto-initialization logic in decorator factory Co-Authored-By: Alex <[email protected]>
- Fix import statement formatting - Apply consistent quote style and spacing - Resolve pre-commit check failures Co-Authored-By: Alex <[email protected]>
…tialized property - Replace patch.object(tracer, 'initialized', False) with patch.object(tracer, '_initialized', False) - Fix side effect function to set tracer._initialized = True - Resolves AttributeError: property 'initialized' has no setter/deleter Co-Authored-By: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Decorator Initialization Failures
Problem
The AgentOps SDK had a critical issue where manual decorators (
@agent,@tool,@task, etc.) failed silently when the tracer was not initialized, while LLM instrumentation continued to work correctly. This created an inconsistent developer experience.Root Cause
The decorator factory in
agentops/sdk/decorators/factory.pycheckedtracer.initializedand simply returned the unwrapped function if not initialized, causing decorators to fail silently without any instrumentation or error indication.Solution
Implemented auto-initialization in the decorator factory following the same pattern used successfully in the
start_trace()function. The fix:Changes Made
agentops/sdk/decorators/factory.pyagentops/__init__.py:start_trace()Testing
Related Issue
Fixes the decorator initialization failures documented in the GitHub issue.
Link to Devin run: https://app.devin.ai/sessions/4e2a6f5d27cb43d9850cc31b46dd24d7