Skip to content

fix(control-plane): fail-closed admin auth + startup warning for empty API key (closes #424, #425) #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yw13931835525-cyber wants to merge 1 commit into from
+18 −2
Closed

fix(control-plane): fail-closed admin auth + startup warning for empty API key (closes #424, #425) #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions control-plane/internal/server/middleware/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,21 @@ func APIKeyAuth(config AuthConfig) gin.HandlerFunc {
}

// AdminTokenAuth enforces a separate admin token for admin routes.
// If adminToken is empty, the middleware is a no-op (falls back to global API key auth).
// Admin tokens must be sent via the X-Admin-Token header only (not Bearer) to avoid
// collision with the API key Bearer token namespace.
// Fixes #425: admin routes are now fail-closed when adminToken is unset (previously
// the middleware was a no-op, silently falling back to API key auth or no auth at all).
func AdminTokenAuth(adminToken string) gin.HandlerFunc {
return func(c *gin.Context) {
if adminToken == "" {
c.Next()
// Fail closed: admin routes are inaccessible if admin token is not configured.
// This prevents accidental exposure of admin routes when the token is misconfigured.
c.AbortWithStatusJSON(http.StatusInternalServerError, gin.H{
"error": "configuration_error",
"message": "admin token is not configured on this server. " +
"Set AGENTFIELD_AUTHORIZATION_ADMIN_TOKEN for production use. " +
"See: https://github.com/Agent-Field/agentfield/issues/425",
})
return
}

Expand Down
8 changes: 8 additions & 0 deletions control-plane/internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,14 @@ func (s *AgentFieldServer) setupRoutes() {
}))
if s.config.API.Auth.APIKey != "" {
logger.Logger.Info().Msg("🔐 API key authentication enabled")
} else {
// SECURITY WARNING: middleware is a no-op when API key is empty (issue #424)
// All non-public routes become accessible without credentials.
// Only public routes (/api/v1/agentic/kb/*, /health, /metrics) are safe without auth.
logger.Logger.Error().Msg("⚠️ SECURITY WARNING: No API key configured (AGENTFIELD_API_AUTH_APIKEY is empty). " +
"API key authentication is disabled — all non-public routes are unprotected. " +
"Set AGENTFIELD_API_AUTH_APIKEY for production deployments. " +
"See: https://github.com/Agent-Field/agentfield/issues/424")
}

// DID authentication middleware (applied globally, but only validates when headers present)
Expand Down