Skip to content

Add support of parsing database comment #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

caifengyin
Copy link
Contributor

support database comment:
CREATE DATABASE [IF NOT EXISTS] db_name [ON CLUSTER cluster] [ENGINE = engine(...)] [COMMENT 'Comment']

@git-hulk
Copy link
Member

git-hulk commented Jun 8, 2025

@caifengyin Thanks for your contribution. Could you please run make update_test to update the test suites?

@git-hulk git-hulk self-requested a review June 8, 2025 12:52
@git-hulk git-hulk force-pushed the feat_support_db_comment branch from 9547842 to 79e509f Compare June 20, 2025 15:56
@git-hulk git-hulk merged commit 3da35a0 into AfterShip:master Jun 20, 2025
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15782884879

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 63.021%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_table.go 3 5 60.0%
parser/ast.go 1 4 25.0%
Totals Coverage Status
Change from base Build 15737131410: -0.02%
Covered Lines: 7134
Relevant Lines: 11320

💛 - Coveralls

@git-hulk git-hulk changed the title feat: support database comment Add support of parsing database comment (#167) Jun 20, 2025
@git-hulk git-hulk changed the title Add support of parsing database comment (#167) Add support of parsing database comment Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants