Skip to content

ci: fix macos-14 zero-test pass by selecting Xcode 16.2#16

Merged
tarkatronic merged 1 commit into
Affirm:mainfrom
tarkatronic:fix/ci-macos14-swift-testing
Jun 15, 2026
Merged

ci: fix macos-14 zero-test pass by selecting Xcode 16.2#16
tarkatronic merged 1 commit into
Affirm:mainfrom
tarkatronic:fix/ci-macos14-swift-testing

Conversation

@tarkatronic

@tarkatronic tarkatronic commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Selects Xcode 16.2 on the macos-14 runner before building/testing, replacing the default Xcode 15.4 (Swift 5.10) which does not discover swift-testing suites and causes swift test to execute 0 tests and vacuously pass.
  • Adds a post-run guard on both matrix entries that fails the job if no Test run with N tests passed line appears in output, providing defense-in-depth against future toolchain regressions.

Test plan

  • Verify macos-14 CI job now executes all 86 tests (not 0)
  • Verify macos-15 CI job continues to pass unchanged
  • Verify the guard step fails correctly if the swift-testing output line is absent

Closes #7

Swift 5.10 (Xcode 15.4, the macos-14 default) does not discover
swift-testing suites, causing `swift test` to execute 0 tests and
vacuously pass. Select Xcode 16.2 on macos-14 so swift-testing tests
are natively discovered and run.

Add a post-run guard on both matrix entries that fails the job if no
'Test run with N tests passed' line appears in the output, catching
any future toolchain regression that re-silences the suite.

Closes Affirm#7

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tarkatronic tarkatronic merged commit 769d2e4 into Affirm:main Jun 15, 2026
2 checks passed
@tarkatronic tarkatronic deleted the fix/ci-macos14-swift-testing branch June 15, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: macos-14 job runs 0 tests and silently passes (Swift 5.10 doesn't discover swift-testing)

1 participant