Added more features to be omitted in the build tags for a leaner Tailscale build. #61
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request changes the approach for creating a leaner Tailscale build for routers by replacing a dynamic feature removal system with explicit build tags. However, the implementation contradicts the PR's stated goal.
Key Changes:
- Replaced
go run ./cmd/featuretags --removewith hardcodedts_omit_*build tags - Added
netgotag for embedded system compatibility - Reduced the number of omitted features from 33 to 15
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| BUILD_TAGS="${BUILD_TAGS},ts_omit_relayserver,ts_omit_taildrop,ts_omit_tpm" | ||
| BUILD_TAGS="${BUILD_TAGS},ts_omit_webclient,ts_omit_drive" | ||
| BUILD_TAGS="${BUILD_TAGS},ts_omit_clientupdate,ts_omit_desktop_sessions,ts_omit_serve" | ||
| BUILD_TAGS="${BUILD_TAGS},osrouter,unixsocketidentity" |
There was a problem hiding this comment.
The PR title states "Added more features to be omitted" but the new approach actually omits fewer features than before. The old code removed 33 features, while the new explicit tags only omit 15 features.
Features previously removed but NO LONGER being omitted include: ace, appconnectors, cliconndiag, cloud, debugeventbus, debugportmapper, doctor, identityfederation, linkspeed, linuxdnsfight, netlog, networkmanager, oauthkey, outboundproxy, posture, resolved, sdnotify, synology, syspolicy, systray, and tailnetlock.
This will result in a larger binary, not a "leaner" one as described. Either:
- The PR title/description is incorrect, or
- Additional ts_omit_* tags should be added to match the original feature set
| BUILD_TAGS="${BUILD_TAGS},osrouter,unixsocketidentity" | |
| BUILD_TAGS="${BUILD_TAGS},ts_omit_ace,ts_omit_appconnectors,ts_omit_cliconndiag,ts_omit_cloud,ts_omit_debugeventbus,ts_omit_debugportmapper,ts_omit_doctor,ts_omit_identityfederation,ts_omit_linkspeed,ts_omit_linuxdnsfight,ts_omit_netlog,ts_omit_networkmanager,ts_omit_oauthkey,ts_omit_outboundproxy,ts_omit_posture,ts_omit_resolved,ts_omit_sdnotify,ts_omit_synology,ts_omit_syspolicy,ts_omit_systray,ts_omit_tailnetlock,osrouter,unixsocketidentity" |
No description provided.