-
-
Notifications
You must be signed in to change notification settings - Fork 34
support x86_64 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
support x86_64 #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for x86_64 architecture by mapping it to the amd64 naming convention in several script functions.
- Introduce x86_64 branch in
preflight_checkto setTINY_ARCHand log architecture. - Extend
get_latest_tailscale_versionandcompress_binariesto handle amd64 binaries for x86_64. - Maintain existing logic for aarch64 and armv7l.
Comments suppressed due to low confidence (1)
update-tailscale.sh:67
- The new x86_64 branches in
preflight_check,get_latest_tailscale_version, andcompress_binariesare not covered by existing tests. Consider adding tests to validate amd64 behavior.
if [ "$ARCH" = "x86_64" ]; then
|
I don't see why x86_x64 should be included since all GL devices are only based on ARM? |
|
I am running OpenWRT in x86_64 VM, and I can only found this script to upgrade tailscale, it will be convenient to add x86_64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.