Skip to content

Conversation

@chengxuncc
Copy link

No description provided.

Copilot AI review requested due to automatic review settings July 10, 2025 21:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for x86_64 architecture by mapping it to the amd64 naming convention in several script functions.

  • Introduce x86_64 branch in preflight_check to set TINY_ARCH and log architecture.
  • Extend get_latest_tailscale_version and compress_binaries to handle amd64 binaries for x86_64.
  • Maintain existing logic for aarch64 and armv7l.
Comments suppressed due to low confidence (1)

update-tailscale.sh:67

  • The new x86_64 branches in preflight_check, get_latest_tailscale_version, and compress_binaries are not covered by existing tests. Consider adding tests to validate amd64 behavior.
    if [ "$ARCH" = "x86_64" ]; then

@Admonstrator
Copy link
Owner

I don't see why x86_x64 should be included since all GL devices are only based on ARM?

@Admonstrator Admonstrator self-assigned this Jul 10, 2025
@Admonstrator Admonstrator added the enhancement New feature or request label Jul 10, 2025
@chengxuncc
Copy link
Author

I am running OpenWRT in x86_64 VM, and I can only found this script to upgrade tailscale, it will be convenient to add x86_64.

@Admonstrator Admonstrator added this to the Add x86/x64 Support milestone Oct 23, 2025
@Admonstrator Admonstrator requested a review from Copilot October 26, 2025 11:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants