-
-
Notifications
You must be signed in to change notification settings - Fork 150
CatRep: UI improvement; add columns for former roles, membership start/end/duration, user profile fields (uuid, login_name, last_login, etc.) #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…uration, user profile fields (uuid, login_name, last_login, etc.) * Add new column type f111 to list former members of the role. Although the CatRep by default only lists current membes, those former members will be included, but the former members column will be marked correspondingly to prevent confusion. * Add new column types b111, e111, d111, uuuid, ulogin_name, ulast_login, unumber_logins * Fix bug where category restrictions in the category report would not be applied at all * Split catrep configuration column type select box into two boxes, where the first allows user to select the role, and the second allows the selection of the role membership property (current/past member, leader, start, end, duration). NOTE: The bNN, eNN and dNN column types still suffer from the multi-membership issue described in issue Admidio#1867. The call to $membership->readDataByColumns returns false if a user has two or more memberships (past and present) on the same role.
|
I didnt't change which roles are considered in either the role selection box, nor the displayed memberships with the adummy or ddummy column types. Do you mean to exclude all event roles from the category report at all? I.e. shall the event roles be removed from the list of column types (the select box in the configuration), too? Or shall they only be excluded from the adummy and ddummy column types? |
|
It was my mistake. I thought that no event roles would be selectable in the category report at this point. However, that is not the case. It can stay as it is and a merge can take place. |
| <string name="SYS_UTF32BE">UTF-32BE</string> | ||
| <string name="SYS_UTF32LE">UTF-32LE</string> | ||
| <string name="SYS_UTF8">UTF-8</string> | ||
| <string name="SYS_UUID">Unique user ID</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Within the list configuration we used SYS_UNIQUE_ID. I think we should use the same string in the category report. So we don't need SYS_UUID translation key.

NOTE: The bNN, eNN and dNN column types still suffer from the multi-membership issue described in issue #1867. The call to $membership->readDataByColumns returns false if a user has two or more memberships (past and present) on the same role.