Improve/fix Contact import #1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kainhofer
commented
Oct 7, 2025
kainhofer
commented
- If a table column has no name/header, use "Column NN" instead (rather than crashing)
- Allow importing usename without password
- Allow using the same column for multiple profile fields
… instead Spreadsheet import returns NULL on empty cells, so a column without headers would have a null value to be displayed in the combobox, causing admidio to crash. This patch makes sure that all columns have a human-readable name for display. Internally, the column index is used anyway.
Allows importing a username without setting a password. The user will need to reset the password immediately. This is much more secure than setting some default password and telling the user via mail.
Rather than looping through all columns of the imported data and retrieve the column to which it is assigned (implicit assumption: each column in the imported data shall only be assigned to one profile field), we now loop through all profile fields that are assigned an import column. Use cases: company name (employer and licensee), names (personal data and contact for business memberships), etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.