-
Notifications
You must be signed in to change notification settings - Fork 23
Agm-2734 Improve AdGuard VPN CLI documentation #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agm-2734 Improve AdGuard VPN CLI documentation #318
Conversation
Fixed navigation issues, added more description to VPN mode and Routing mode sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
|
||
| AdGuard VPN CLI brings the TUN interface up but does not modify the system routing table. No default route to the tunnel is installed — traffic continues to use existing OS routes. | ||
|
|
||
| Use this if you want to manage routes yourself (manually or with third-party tools), or when you only use the SOCKS5 proxy mode and do not need the system to push traffic into the TUN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you only use the SOCKS5 proxy mode and do not need the system to push traffic into the TUN.
It sounds like this setting has some meaning in SOCKS5 mode, while this setting does not relate to it.
I'd prefer to not to mention it.
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
|
||
| DNS behavior depends on the `set-change-system-dns` parameter: | ||
|
|
||
| - `on` (default): System DNS settings are changed to route DNS queries through the VPN tunnel to the DNS server specified in `set-dns` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set-dns — это то же самое, что и set-change-system-dns parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SelYui помоги, пожалуйста, ответить.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нет, это две разные команды. Их описание есть ниже:
To set a DNS upstream, type:
adguardvpn-cli config set-dns <server_address>
Replace <server_address> with the address of your DNS server. To use this DNS server at the system level, type:
adguardvpn-cli config set-system-dns on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@el-termikael в итоге перенесли всю dns related инфу в раздел про DNS upstream address
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
7 similar comments
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
|
Preview was deployed to: https://pull-request-318.kb-vpn.pages.dev/ |
Fixed navigation issues, added more description to VPN mode and Routing mode sections