Skip to content

Conversation

@CEsGutierrez
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? I think I created thoughtful variable names, good spacing and indentations. I hopefully added good comments.
How did your code keep track of user input? The program has variables for tracking the "operation", "first_num" and "second_num" These variables are largely unmolested throughout the code.
How did your code determine what operation to perform? It checked the user input's for operation against an array that included possible inputs, for example it will add if the user entered "add" "addition" or "+"
What opportunities exist to create small methods for this project? Checking that the user entered a valid operator could have been done with a brief method.
In the next project, what would you change about your process? What would you keep doing? Lines 46 and 54 do not call the input from the method and thus keep "9" from "9banana" rather than "3" if the user fixed it to "3" as part of the method. I would like to figure this out.

# Broken at line 20. Please do not enter 9banana.
Broken loop fixed by Mariya Burrows ~ 
Issue that was solved: if the user entered a correction as part of the number validation, the corrected (new) value was not used during the operation.
@jmaddox19
Copy link

Calculator

What We're Looking For

Feature Feedback
Readable code with consistent indentation X
Practices using variables appropriately X
Practices using conditionals appropriately X
If any, practices iteration appropriately X
If any, practices using custom methods appropriately X
Takes in two numbers and an operator and can perform addition X
Takes in two numbers and an operator and can perform subtraction X
The program handles divide when attempting to divide by zero X

Haha. I'm a big fan of your divide by zero message. Love that you gave the program some character.
Also very impressed by your edge-casing. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants