Branches - Xinran

[gracexinran]

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	Variable names and spacing. Lacking: looks too crowd
How did your code keep track of user input?	Assign each input to meaningful variables
How did your code determine what operation to perform?	Input operation symbol or name
What opportunities exist to create small methods for this project?	Display the operators as each time the input is invalid user has to select the operator again.
In the next project, what would you change about your process? What would you keep doing?	Pseudocode first to avoid missing something. I'll keep making my codes work for most of conditions.

[tildeee]

Calculator

What We're Looking For

Feature	Feedback
Readable code with consistent indentation	x
Practices using variables appropriately	x
Practices using conditionals appropriately	x
If any, practices iteration appropriately	x
If any, practices using custom methods appropriately	x
Takes in two numbers and an operator and can perform addition	x
Takes in two numbers and an operator and can perform subtraction	x
The program handles divide when attempting to divide by zero	x

Well done on this project, Xinran!

I think that your code is very organized, readable, and logical. You have a great solution for calculator, and you did a lot of nice, clever things. Your conditionals, loops, and methods look great!

If you had more time on this project, I may suggest looking over your code to see that there are more opportunities for methods to be pulled out. For example, getting the user input for the two numbers is some repeated code. I've also left some comments with other small suggestions.

Overall, your code looks great! I really love the methods you pulled out and how you organized the code and your use of the cool array things, like .include and .join. Well done!

[tildeee]

Nice strategy!

[tildeee]

I LOVE that you created a separate method used to display information! Keep doing things like this!

[tildeee]

I prefer my methods to have names that are like actions (so, method names that start with verbs). I may suggest renaming this method to display_calculator_methods or show_calculator_methods, just like how you named a method perform_calculation_two_numbers

[tildeee]

Here, you deal with the case such that if num2 is negative, you say to take the -num2 of it. Instead of making num2 negative, could you consider taking the absolute value of num2? You can do that in Ruby using .abs, so here, consider:

(num2.abs).to_i.times do
  exponent_arr << num1
end