Add --language and --namespace flags to state import
#3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
reviewed
Jul 25, 2025
mitchell-as
approved these changes
Jul 25, 2025
|
Actually, no, can I take back my approval? We need to run the import tests AFTER you merge https://github.com/ActiveState/TheHomeRepot/pull/17010. Please merge that first, then re-run all of the import tests. If they pass, then I approve of this PR. |
|
@mitchell-as pretty sure you can just review again, even if you're not prompted for it. |
mitchell-as
previously approved these changes
Jul 28, 2025
mitchell-as
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with https://github.com/ActiveState/TheHomeRepot/pull/17010 to allow importing any language given the supported formats.