Tolerate object-valued bower license property#17
Open
pkaminski wants to merge 1 commit intoAceMetrix:masterfrom
Open
Tolerate object-valued bower license property#17pkaminski wants to merge 1 commit intoAceMetrix:masterfrom
pkaminski wants to merge 1 commit intoAceMetrix:masterfrom
Conversation
I found at least one Bower package (`serialized-lru-cache`) that defines its license as:
```
"license": {
"type": "MIT",
"url": "http://github.com/jmendiara/serialized-lru-cache/raw/master/LICENSE"
},
```
No idea if it's spec-compliant or not, but it will crash `bower-license` and it's a simple fix, so...
Contributor
|
I think this is a "bug" in the bower-config of |
Member
|
I agree, I don't think the library should be parsing arbitrary specs, but the crashing is not good. I think what makes sense is simply to check for type: |
Author
|
OK, I opened a PR against serialized-lru-cache: jmendiara/serialized-lru-cache#1 FWIW, the spec you pointed to also allows an array of strings for the |
Contributor
|
Fixed in jmendiara/serialized-lru-cache#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found at least one Bower package (
serialized-lru-cache) that defines its license as:No idea if it's spec-compliant or not, but it will crash
bower-licenseand it's a simple fix, so...This change is