fix(api): Restore definition of OIIO_NAMESPACE_USING macro #4920
Conversation
Version 3.2 removed this definition because we didn't use it anywhere. But downstream projects did. Oops. Signed-off-by: Larry Gritz <[email protected]>
|
The thing I know is broken as a result of this is Blender, but @jessey-git says just leave it as-is and he'll fix on his end. I will leave this PR up in case anybody else runs across this problem and wants it fixed. But if after a week I don't hear back from anybody saying yes they need it, I will close without merging. |
|
Hi @lgritz! I actually just stumbled across this myself trying to build OpenUSD against the recently released 3.1.6.1, as it seems there are two usages of https://github.com/PixarAnimationStudios/OpenUSD/blob/a7c0637241a4fedce0338337bd7c63746c3d06eb/pxr/imaging/plugin/hioOiio/metadata.cpp#L21 I can propose a PR to OpenUSD to change those to just |
|
Lol... I just posted on slack about this and yes please open a PR else I will do so tomorrow. |
|
Sounds good, the OpenUSD PR is here: Thank you both! |
|
Oh dear, that's two package impacted. I'll merge this and put out a patch release. So sorry for botching this. |
…ftwareFoundation#4920) Version 3.1 removed this definition, thinking it was safe because we didn't use it anywhere, didn't document it, and what it expands to (`using namespace OIIO`) isn't any longer than the macro name, so is pointless to use. But downstream projects did use it. Oops. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added
bug
3 participants
Version 3.1 removed this definition, thinking it was safe because we didn't use it anywhere, didn't document it, and what it expands to (
using namespace OIIO) isn't any longer than the macro name, so is pointless to use.But downstream projects did use it. Oops.