Restore render tests in standard OSL #2682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist restores a handful of render tests in standard OSL, allowing them to be included in GLSL/OSL/MDL comparisons. These render tests were marked as skipped as part of the new OSO building functionality, so this changelist leaves them as skipped when `MATERIALX_BUILD_OSOS` is set.
Member
Author
|
Here's a new GLSL/OSL render comparison using the code in this changelist, where previous render comparisons were missing OSL images for several material examples that are supported in both GLSL and OSL: |
chellmuth
approved these changes
Nov 17, 2025
Contributor
chellmuth
left a comment
chellmuth
left a comment
There was a problem hiding this comment.
Thanks for catching that, this LGTM, but would it make more sense to wrap those ignores in an if (_useOslCmdStr) instead of the ifdef?
Member
Author
|
Good suggestion, @chellmuth, and I've made that change. |
Member
Author
|
@ld-kerley I've added the new pbrlib tests to this change as recommended in #2683, and let me know how this looks to you. |
ld-kerley
approved these changes
Nov 18, 2025
Contributor
ld-kerley
left a comment
ld-kerley
left a comment
There was a problem hiding this comment.
looks good to me - I have a few more updates cooking that I hope will end up reducing this list again
jstone-lucasfilm
merged commit 19ee9f3
into
AcademySoftwareFoundation:main
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist restores a handful of render tests in standard OSL, allowing them to be included in GLSL/OSL/MDL comparisons.
These render tests were marked as skipped as part of the new OSO building functionality, so this changelist leaves them as skipped when
MATERIALX_BUILD_OSOSis set.