fix(web3-react-agw): pass eth_accounts params to wallet_requestPermissions#368
Open
kinderjoypresents wants to merge 1 commit intoAbstract-Foundation:mainfrom
Conversation
|
PR SummaryImproves activation reliability by explicitly requesting account permissions.
Written by Cursor Bugbot for commit f758196. This will update automatically on new commits. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Tweaked
wallet_requestPermissionsto always requesteth_accountstoo.Why
A few providers don’t like permission requests without params, so this makes activation a bit more reliable / consistent.
Impact
PR-Codex overview
This PR modifies the request to the provider in the
packages/web3-react-agw/src/index.tsfile to include parameters for requesting Ethereum accounts. This change aims to ensure that account and chain ID requests are handled serially for better user interaction.Detailed summary
params: [{ eth_accounts: {} }]to thewallet_requestPermissionsmethod call.