Experimental/129 get generate negotiate #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo code coverage report - scala:2.12.17
|
# Conflicts: # api/src/main/scala/za/co/absa/loginsvc/rest/SecurityConfig.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows an experimental GET endpoint at
/token/experimental/get-generatethat supports1 spnego negotiate from browser
2 basic auth
This endpoint will only work if config allows it - via
loginsvc.rest.experimental.enabled=true(otherwise throws 409)Test run:
Tested to work at
https://login-service-dev.npintdebdtools.aws.dsarena.com/token/experimental/get-generate
with Edge and Chromium.
Chrome with
AuthNegotiateDelegateAllowlistsetDoes not currently work in Chrome because it has
AuthNegotiateDelegateAllowlist-- and LS is not in the allowed list. (We may try to add LS endpoint to be included)Release notes:
/token/experimental/get-generateadded (must be allowed in config vialoginsvc.rest.experimental.enabled=true)Closes #129