Skip to content

Revised handling of unknown warnings #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xavierleroy
Copy link
Contributor

Currently, unrecognized warning options -Wsome-unknown-warning are fatal errors.

As suggested in #552, this PR makes sure that -Wsome-unknown-warning is a warning (by default), and that -Wno-some-unknown-warning is ignored. This is what GCC and Clang do.

This commit also introduces the unknown-warning-option warning, so that warnings about unknown warnings can be ignored (-Wno-unknown-warning-option) or turned into an error (-Werror=unknown-warning-option). This is what Clang does.

Closes: #552

`-W<some unknown warning>` is now (by default) a warning (not a fatal error)
and `-Wno-<some unknown warning>` is ignored.
This is what GCC and Clang do.

This commit also introduces the `unknown-warning-option` warning, so
that warnings about unknown warnings can be ignored
(`-Wno-unknown-warning-option`) or turned into an error
(`-Werror=unknown-warning-option`).  This is what Clang does.

Closes: #552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade unrecognized -W<warning> from an error to a warning
1 participant