You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for proposing this idea. I don't think we should encourage implicit parameters with default values, especially when combined with optionality. OptArgs are often used in contexts where explicitness is highly desired (e.g. configuration, application bootstrap).
Thank you for proposing this idea. I don't think we should encourage implicit parameters with default values, especially when combined with optionality. OptArgs are often used in contexts where explicitness is highly desired (e.g. configuration, application bootstrap).
we do not encourage implicit parameters with default values. The default ones still must be passed explicitly (how it's already done internally with MaybeClientSession in DHCP and CAE with UserContext).
But I see, this mechanism could be abused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImplicitOptArgis likeOptArg, but also accept implicit parameters (useful for DI or context parameters)Example usage: