Expand JPL deploy policy for ITS_LIVE #2936
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhkennedy
force-pushed
the
jpl-deploy-policy
branch
from
f4b93b0 to
53ed0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its-live-monitoring is deployed with the hyp3-ci deploy policy, and it hasn't been able to deploy since I updated the hyp3-ci stacks with the changes in #2809, because I rolled back the permissions reflected here, which are needed because it has multiple deployment stacks across regions:
https://github.com/ASFHyP3/its-live-monitoring/blob/develop/.github/actions/deploy/action.yml
I don't see a problem expanding this policy, personally, but alternatively, we could set up a deploy policy specifically for its live monitoring and other monitoring stacks.
❔ Should I make the same changes for the ASF deployment stacks too?
I've confirmed its-live-monitoring is able to deploy again with these changes, but I haven't applied it to the other JPL AWS accounts.
TODOs:
Deploy to the JPL AWS accounts: