Skip to content

Conversation

@travis3630
Copy link

Add target device api for nrf7120.

@travis3630
Copy link
Author

Ready for merge

@avinaw01-arm
Copy link
Collaborator

Hi @travis3630
Thank you for reaching out to us. Before we merge your new platform, I request you to update all modified/added files with latest year in Copyright header. For example, Copyright (c) 2025 for new files, and Copyright (c) 20XX-2025 for modified files.

Porting a new target in psa-arch-tests now follows updated guidelines. The old method for updating Target configurations is no longer used. Please check the new porting guidelines in the following file and update your commit accordingly. File-path: <psa-arch-tests>/api-tests/docs/porting_guide_dev_apis.md.
You may also look at the existing platform files in the 'main' branch. We recommend checking the files for tgt_dev_apis_tfm_an521 target as a good example.

Please update your commit with the above changes. We can review and merge it afterward.
If you have any questions, please feel free to reach out to us.

@travis3630 travis3630 force-pushed the WZN-5116-nrf7120-support-psa-arch-tests branch from 63a38e7 to 7ef9533 Compare November 27, 2025 12:19
@travis3630
Copy link
Author

Updated , thanks

@avinaw01-arm
Copy link
Collaborator

Thanks for updating the Copyright headers. I would request you to port the platform according to the latest guidelines mentioned in the file: <psa-arch-tests>/api-tests/docs/porting_guide_dev_apis.md.
We can review and merge post that.

@travis3630 travis3630 force-pushed the WZN-5116-nrf7120-support-psa-arch-tests branch from 7ef9533 to e6911dd Compare November 27, 2025 17:02
@travis3630
Copy link
Author

Updated, is that what you mean?

@avinaw01-arm
Copy link
Collaborator

Yes, that's what I wanted to convey.
I can see that you are utilizing the value of WATCHDOG_4_BASE in your pal_driver_intf.c file, but you have marked it as “// Unused” in the platform configurations. The same applies to the subsequent similar macros in the sequence, if applicable.

Could you please rectify this and send us the final commit for review? Thanks.

Add target device api for nrf7120.

Signed-off-by: Travis Lam <[email protected]>
@travis3630 travis3630 force-pushed the WZN-5116-nrf7120-support-psa-arch-tests branch from e6911dd to c80c5c6 Compare November 28, 2025 10:36
@travis3630
Copy link
Author

The "// Unused" should be removed , updated

@avinaw01-arm
Copy link
Collaborator

Thank you @travis3630.
Please allow us some time to review internally and then we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants