Fixed some bugs and added QoL features#181
Merged
APickledWalrus merged 10 commits intoAPickledWalrus:dev/1.4.0from Jan 17, 2025
Merged
Fixed some bugs and added QoL features#181APickledWalrus merged 10 commits intoAPickledWalrus:dev/1.4.0from
APickledWalrus merged 10 commits intoAPickledWalrus:dev/1.4.0from
Conversation
Fixed some bugs regarding removeable/stealable GUI items
Owner
|
I'll take a look into reviewing this soon, sorry for the delay |
APickledWalrus
requested changes
Aug 22, 2024
Owner
APickledWalrus
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Here are some of the things that I noticed. Please feel free to reply to any of my comments if you have any questions/thoughts 🙂
src/main/java/io/github/apickledwalrus/skriptgui/elements/sections/SecMakeGUI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/elements/sections/SecSlotChange.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/GUIEventHandler.java
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Outdated
Show resolved
Hide resolved
… and the opposite Removed unwanted code
Author
I have committed the updated code, fixing all the previous mistakes |
APickledWalrus
requested changes
Aug 23, 2024
src/main/java/io/github/apickledwalrus/skriptgui/elements/sections/SecMakeGUI.java
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Outdated
Show resolved
Hide resolved
…ions/SecMakeGUI.java Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
…IEvents.java Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
APickledWalrus
requested changes
Aug 26, 2024
Owner
APickledWalrus
left a comment
There was a problem hiding this comment.
Mainly just the one change that needs further testing. Other than that, this should be good to go. Thank you for your work!!
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Show resolved
Hide resolved
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Show resolved
Hide resolved
…IEvents.java Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
src/main/java/io/github/apickledwalrus/skriptgui/gui/events/GUIEvents.java
Outdated
Show resolved
Hide resolved
APickledWalrus
approved these changes
Jan 17, 2025
Owner
APickledWalrus
left a comment
There was a problem hiding this comment.
This looks good. Thanks for your work!
APickledWalrus
approved these changes
Jan 17, 2025
This was referenced Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Made stealable items moveable regardless whether they were in a section or no
Why: If someone specifically marked a slot as stealable, i see NO reason why this should still be cancelling the event. To move sectioned slots the slot itself has to be stealable, if the gui is stealable but the slot isn't then it won't let you move it
Made a new Slot Changed section, which is triggered when a specific slot was changed
Why: This makes it easier to detect changes. Before, it wasn't even possible to detect when you instantly move an item from your inventory into the GUI. Most of the time, cancelling the event won't do anything in a Slot Changed section. You might think this is useless but it has (for me at least) alot of usecases, such as custom anvil or custom crafting table
Some changes to the code
Why: Some parts were causing a warning because they weren't properly coded, such as
if List#size == 0instead ofif List#isEmptyFor the most part, I added stuff to skript-gui. It won't affect others and would be useful in some situations. So I hope this PR get's accepted or added in some way