Skip to content

Update core_ca.h#1

Open
ANOSTM wants to merge 2 commits intodevelopfrom
ANOSTM-patch-1
Open

Update core_ca.h#1
ANOSTM wants to merge 2 commits intodevelopfrom
ANOSTM-patch-1

Conversation

@ANOSTM
Copy link
Owner

@ANOSTM ANOSTM commented Mar 22, 2023

Inverted parameters in MMU_GetSectionDescriptor() and MMU_GetPageDescriptor()

In CMSIS v5.8.0 (and also in v5.9.0), some parameters are inverted in CMSIS/Core_A/Include/core_ca.h
The call of MMU_APPage and MMU_APSection are not aligned with their definitions ( user <> priv).

Inverted parameters in MMU_GetSectionDescriptor() and MMU_GetPageDescriptor()
@JonatanAntoni
Copy link

Thanks for preparing this.
May I ask you to

  • update file version in line 4
  • update file data in line 5
  • change PR to target develop branch in upstream repository

I am happy to accept this change and merge it right away.

@ANOSTM
Copy link
Owner Author

ANOSTM commented Mar 23, 2023

OK I changed version and date.
As I'm not familiar with Pull Request, how I can change dev branch in upstream ?

@JonatanAntoni
Copy link

Perfect! In your view of this PR there should be an "Edit" button in the top of the page. If you go there, you should be able to change the target branch for the PR. If nothing went wrong, you should be able to select ARM-software/CMSIS_5/develop instead of your own repos develop branch. If this can't be changed anymore, you can try to create a new PR directly to the upstream repo.

@ANOSTM
Copy link
Owner Author

ANOSTM commented Mar 23, 2023

Not possible to change this PR.
I create a new one : ARM-software#1613
It should be correct now.
If the new PR is OK for you, I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants