BCP-004-01: Factor BCP-004-01 tests into dedicated test suite.#861
Open
jonathan-r-thorpe wants to merge 2 commits intoAMWA-TV:masterfrom
Open
BCP-004-01: Factor BCP-004-01 tests into dedicated test suite.#861jonathan-r-thorpe wants to merge 2 commits intoAMWA-TV:masterfrom
jonathan-r-thorpe wants to merge 2 commits intoAMWA-TV:masterfrom
Conversation
Collaborator
|
I think those tests must be updated to support manufacturer namespace and fix a few issues. For example it is not possible to require manufacturer capabilities to be in the NMOS parameter registers. Also the verification for capabilities to be used with the appropriate format assumes that it knows all the capabilities ... for example urn:x-nmos:cap:format:profile is defined as a video capability ... which is not 100% true as someday when supporting AAC audio it will also be an audio capability. I think the tests must not assume having knowledge of that kind of information. test_08 should not consider constraint set that are disabled as it would be invalid to put the media_type of such constraint set in media_types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCP00401Test.pyIS0401Test.pywith: