Conversation
- Created new file `ALFI/ALFI/ratf.h` with `alfi::ratf` namespace for rational function. - Implemented a `std::pair`-interchangeable class `RationalFunction`.
- Replaced `RationalFunction` class with an alias for `std::pair<Container<Number>, Container<Number>>`. - Added `alfi::util::numeric::binpow` function for binary exponentiation. - Added `val`, `val_mul`, and `val_div` functions in `alfi::ratf` for scalars and vectors.
- Created new file `ALFI/ALFI/util/poly.h` for utility functions for polynomial operations. - Implemented `normalize`, `mul`, `div`, and `extended_euclid` functions in `alfi::util::poly`. - Implemented `alfi::ratf::pade` function using `extended_euclid`.
This is done to fix false negative results, for example, with the [2/2] approximation of x^5. It also simplifies the code and improves performance.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pasabanov
force-pushed
the
pade
branch
4 times, most recently
from
7e6f227 to
7577c8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
New features:
ALFI/ALFI/ratf.hwithalfi::ratfnamespace for rational functions.RationalFunctiontype as an alias forstd::pair<Container<Number>, Container<Number>>.val,val_mul, andval_divfunctions for scalars and vectors.padefunction for computing Pade approximant aboutNew utility functions:
ALFI/ALFI/util/poly.hwith utility functions for polynomial operations.normalize,mul, anddivfunctions inalfi::util::poly.alfi::util::numeric::binpowfunction for binary exponentiation.Added documentation for all new functions and namespaces.
Implemented basic tests and benchmarks for rational functions and Pade approximation.