Skip to content

Add Python 3.14 and remove Python 3.9#37

Merged
victor-villar merged 2 commits intomainfrom
vv-py314
Jan 9, 2026
Merged

Add Python 3.14 and remove Python 3.9#37
victor-villar merged 2 commits intomainfrom
vv-py314

Conversation

@victor-villar
Copy link
Copy Markdown
Collaborator

Add Python 3.14 and remove Python 3.9

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @victor-villar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating key Rust dependencies, specifically the pyo3 and once_cell crates, across the project's Cargo.toml and Cargo.lock files. These updates are essential for maintaining compatibility and leveraging improvements in the Rust-Python interoperability layer. Although the PR title mentions adding Python 3.14 and removing Python 3.9 support, the provided patches only reflect the dependency upgrades that would likely precede such Python version changes, rather than the direct configuration for Python environments.

Highlights

  • pyo3 Dependency Update: The pyo3 crate, which provides Rust bindings for Python, has been updated across the project. Specifically, pyo3 was upgraded from version 0.24.x to 0.27.2 in both examples/grid_world/Cargo.toml and rust/Cargo.toml, and their corresponding Cargo.lock files. This update includes changes to its internal dependencies, such as the removal of cfg-if from pyo3 and once_cell from pyo3-build-config.
  • once_cell Dependency Update: The once_cell crate, used for one-time initialization, has been updated from version 1.20.2 to 1.21.3 in rust/Cargo.lock. This is a minor version bump, likely bringing bug fixes or small improvements.
  • Python Version Support (Implicit): While the provided patches directly show Rust dependency updates, the pull request title indicates an intention to "Add Python 3.14 and remove Python 3.9". The pyo3 update is a crucial step towards supporting newer Python versions like 3.14, as pyo3 versions often align with Python compatibility. The actual configuration changes for Python 3.14/3.9 support are not present in the provided diffs.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pyo3 dependency to version 0.27.2, which is a major version bump. However, it misses the necessary code adaptations in the Rust source files to account for breaking changes that are typical for such updates. This will likely lead to compilation failures. I have left comments on the Cargo.toml files with more details. The PR should be updated to include the required code changes for the new pyo3 version.


[dependencies]
pyo3 = { version = "0.24", features = ["extension-module"] }
pyo3 = { version = "0.27.2", features = ["extension-module"] }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to pyo3 version 0.27.2 is a major version bump. The twisterl crate, which this example depends on, also needs to be updated to handle breaking changes in this new pyo3 version. This pull request is missing the necessary code adaptations in the twisterl crate. Without these changes, this example will fail to build. Please include the necessary code changes for twisterl to support pyo3 v0.27.2.

Comment thread rust/Cargo.toml

[dependencies]
pyo3 = { version = "0.24.2", features = ["extension-module", "multiple-pymethods"], optional = true }
pyo3 = { version = "0.27.2", features = ["extension-module", "multiple-pymethods"], optional = true }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating pyo3 from 0.24.2 to 0.27.2 is a major version change. Such updates usually include breaking API changes that require updates to the code using the library. This pull request is missing the necessary code adaptations for the new pyo3 version. Without them, the project will likely fail to compile or run correctly. Please add the required code changes to this PR.

Copy link
Copy Markdown
Collaborator

@jesus-talavera-ibm jesus-talavera-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@victor-villar victor-villar merged commit be5371a into main Jan 9, 2026
7 checks passed
@victor-villar victor-villar deleted the vv-py314 branch January 9, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants