Add Python 3.14 and remove Python 3.9#37
Conversation
Summary of ChangesHello @victor-villar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating key Rust dependencies, specifically the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the pyo3 dependency to version 0.27.2, which is a major version bump. However, it misses the necessary code adaptations in the Rust source files to account for breaking changes that are typical for such updates. This will likely lead to compilation failures. I have left comments on the Cargo.toml files with more details. The PR should be updated to include the required code changes for the new pyo3 version.
|
|
||
| [dependencies] | ||
| pyo3 = { version = "0.24", features = ["extension-module"] } | ||
| pyo3 = { version = "0.27.2", features = ["extension-module"] } |
There was a problem hiding this comment.
This update to pyo3 version 0.27.2 is a major version bump. The twisterl crate, which this example depends on, also needs to be updated to handle breaking changes in this new pyo3 version. This pull request is missing the necessary code adaptations in the twisterl crate. Without these changes, this example will fail to build. Please include the necessary code changes for twisterl to support pyo3 v0.27.2.
|
|
||
| [dependencies] | ||
| pyo3 = { version = "0.24.2", features = ["extension-module", "multiple-pymethods"], optional = true } | ||
| pyo3 = { version = "0.27.2", features = ["extension-module", "multiple-pymethods"], optional = true } |
There was a problem hiding this comment.
Updating pyo3 from 0.24.2 to 0.27.2 is a major version change. Such updates usually include breaking API changes that require updates to the code using the library. This pull request is missing the necessary code adaptations for the new pyo3 version. Without them, the project will likely fail to compile or run correctly. Please add the required code changes to this PR.
Add Python 3.14 and remove Python 3.9