Fix SIGBUS crash on macOS ARM64 by removing unsafe pointer extraction#36
Closed
Fix SIGBUS crash on macOS ARM64 by removing unsafe pointer extraction#36
Conversation
Member
Author
|
After the last release of qiskit-gym https://pypi.org/project/qiskit-gym/0.2.0/, this issue does not appear anymore. Closing this PR for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__extract_env__()method that caused memory corruption across different compiled modulesclone()method to PyBaseEnv for safe environment cloning via Python interfacePyBaseEnvWrapperfor external Rust environments (likeGridWorld) that extendPyBaseEnvDescription
Problem
When external packages like
qiskit-gymstatically link TwisteRL and create their own Rust environments, callingevaluate()orcollect()would cause a SIGBUS crash (exit code 138) on macOS ARM64. This happened even with num_cores=1, ruling out parallelism as the cause. The root cause was the unsafe pointer extraction pattern in__extract_env__()which cast raw pointers between different compilation units with incompatible vtable layouts.Solution