This repository was archived by the owner on Apr 17, 2026. It is now read-only.
bug: add LogWorkflowRun logger#16
Merged
maximilien merged 3 commits intoAI4quantum:mainfrom Oct 10, 2025
Merged
Conversation
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
maximilien
approved these changes
Sep 26, 2025
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Can we have some tests? Free now with LLMs :)
maximilien
approved these changes
Oct 8, 2025
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
LGTM... although I would look into zap from Uber: https://github.com/uber-go/zap It's best logging for Golang IMO.
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9
Add LogWorkflowRun Log