Skip to content

cursor-fix #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

cursor-fix #1287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea55b4
cursor-fix
sagarika-padmanaban Sep 24, 2025
b485ba3
fix
sagarika-padmanaban Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 82 additions & 60 deletions src/ui/pages/container/CL-Transcription/TranscriptionRightPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ const TranscriptionRightPanel = ({
message: "",
variant: "success",
});
const [cursorPositions, setCursorPositions] = useState({});
const [showPopOver, setShowPopOver] = useState(false);
const [selectionStart, setSelectionStart] = useState();
const [currentIndexToSplitTextBlock, setCurrentIndexToSplitTextBlock] =
Expand Down Expand Up @@ -400,6 +401,11 @@ const TranscriptionRightPanel = ({
const changeTranscriptHandler = (event, index, updateAcoustic = false) => {
const { value } = event.target;
const { currentTarget } = event;
const { selectionStart, selectionEnd } = event.target; // Add this line
setCursorPositions(prev => ({
...prev,
[index]: { selectionStart, selectionEnd, updateAcoustic }
}));

// Get the appropriate text field
const oldText = updateAcoustic
Expand Down Expand Up @@ -605,48 +611,45 @@ const TranscriptionRightPanel = ({
if (undoStack?.length > 0) {
const lastAction = undoStack[undoStack.length - 1];

if (lastAction.type === "textChange") {
// Handle verbatim text undo
const currentText = subtitles[lastAction.index]?.text || "";
if (lastAction.type === "textChange" || lastAction.type === "textChangeAcoustic") {
const updateAcoustic = lastAction.type === "textChangeAcoustic";
const currentText = updateAcoustic
? subtitles[lastAction.index]?.acoustic_normalised_text || ""
: subtitles[lastAction.index]?.text || "";

const sub = onSubtitleChange(
lastAction.previousText,
lastAction.index,
false // updateAcoustic flag
);
dispatch(setSubtitles(sub, C.SUBTITLES));
const sub = onSubtitleChange(
lastAction.previousText,
lastAction.index,
updateAcoustic
);
dispatch(setSubtitles(sub, C.SUBTITLES));

setRedoStack((prevState) => [
...prevState,
{
type: "textChange",
index: lastAction.index,
previousText: currentText,
updateAcoustic: false,
},
]);
} else if (lastAction.type === "textChangeAcoustic") {
// Handle acoustic text undo
const currentText =
subtitles[lastAction.index]?.acoustic_normalised_text || "";
// Restore cursor position
setTimeout(() => {
const textareaIndex = updateAcoustic
? lastAction.index + currentPageData?.length
: lastAction.index;
const textarea = textRefs.current[textareaIndex];
if (textarea) {
const oldPos = cursorPositions[lastAction.index];
if (oldPos) {
textarea.setSelectionRange(oldPos.selectionStart, oldPos.selectionStart);
}
textarea.focus();
}
}, 0);

const sub = onSubtitleChange(
lastAction.previousText,
lastAction.index,
true // updateAcoustic flag
);
dispatch(setSubtitles(sub, C.SUBTITLES));

setRedoStack((prevState) => [
...prevState,
{
type: "textChangeAcoustic",
index: lastAction.index,
previousText: currentText,
updateAcoustic: true,
type: updateAcoustic ? "textChangeAcoustic" : "textChange",
index: lastAction.index,
previousText: currentText,
updateAcoustic: updateAcoustic,
},
]);
} else if (lastAction.type === "doubleHash") {
} else if (lastAction.type === "doubleHash") {
// Undo double-hash action
const elementsWithBoxHighlightClass = document.getElementsByClassName(
classes.boxHighlight
Expand Down Expand Up @@ -689,50 +692,69 @@ const onRedo = useCallback(() => {
if (redoStack?.length > 0) {
const lastAction = redoStack[redoStack.length - 1];

if (lastAction.type === "textChange") {
// Handle verbatim text redo
const currentText = subtitles[lastAction.index]?.text || "";

// Redo text change
if (lastAction.type === "textChange" || lastAction.type === "textChangeAcoustic") {
const updateAcoustic = lastAction.type === "textChangeAcoustic";
const currentText = updateAcoustic
? subtitles[lastAction.index]?.acoustic_normalised_text || ""
: subtitles[lastAction.index]?.text || "";

const sub = onSubtitleChange(
lastAction.previousText,
lastAction.index,
false
updateAcoustic
);
dispatch(setSubtitles(sub, C.SUBTITLES));

// Restore cursor position
setTimeout(() => {
const textareaIndex = updateAcoustic
? lastAction.index + currentPageData?.length
: lastAction.index;
const textarea = textRefs.current[textareaIndex];
if (textarea) {
const oldPos = cursorPositions[lastAction.index];
if (oldPos) {
textarea.setSelectionRange(oldPos.selectionStart, oldPos.selectionStart);
}
textarea.focus();
}
}, 0);

// Push undo version of this action
setUndoStack((prevState) => [
...prevState,
{
type: "textChange",
type: updateAcoustic ? "textChangeAcoustic" : "textChange",
index: lastAction.index,
previousText: currentText,
updateAcoustic: false
},
]);
}
else if (lastAction.type === "textChangeAcoustic") {
// Handle acoustic text redo
const currentText = subtitles[lastAction.index]?.acoustic_normalised_text || "";

const sub = onSubtitleChange(
lastAction.previousText,
lastAction.index,
true // updateAcoustic flag
);
dispatch(setSubtitles(sub, C.SUBTITLES));
updateAcoustic: updateAcoustic,

setUndoStack((prevState) => [
...prevState,
{
type: "textChangeAcoustic",
index: lastAction.index,
previousText: currentText,
updateAcoustic: true
},
]);
}
// else if (lastAction.type === "textChangeAcoustic") {
// // Handle acoustic text redo
// const currentText = subtitles[lastAction.index]?.acoustic_normalised_text || "";

// const sub = onSubtitleChange(
// lastAction.previousText,
// lastAction.index,
// true // updateAcoustic flag
// );
// dispatch(setSubtitles(sub, C.SUBTITLES));

// setUndoStack((prevState) => [
// ...prevState,
// {
// type: updateAcoustic ? "textChangeAcoustic" : "textChange",
// index: lastAction.index,
// previousText: currentText,
// updateAcoustic: updateAcoustic,

// },
// ]);
// }

else if (lastAction.type === "doubleHash") {
// Redo double-hash action
Expand Down