Fix failing and slow testing suite#1380
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 31 31
Lines 6447 6448 +1
=======================================
+ Hits 5423 5424 +1
Misses 1024 1024 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I've only had a cursory look at what tests are failing (spent the morning trying to recover what looks like a failed harddrive so on a temporary computer that isn't ideally configured). You could try adding a I'd probably want to check what is changing in the images though but I'm afraid I don't have time to investigate that myself right now (perhaps add them to #1377 if they are readily available they will be under somewhere like |
ns-rse
left a comment
There was a problem hiding this comment.
Perhaps make it easier for people to find why the versions have been pinned.
|
To do:
|
98bc988 to
cd36f1f
Compare
adds skip on 3.10 and updates baseline images
adds skip on 3.10 and updates baseline images
adds skip on 3.10 and updates baseline images
8d7d986 to
9154da6
Compare
|
Test are failing due to a bug introduced in #1376, looks like it is caught and fixed in #1382 Edit: Tests passing on my fork where I haven't added #1376 yet |
There was a problem hiding this comment.
Interesting that this changed too since it is only supposed to be a font change from what we were talking about. But I am not concerned.
tobyallwood
left a comment
There was a problem hiding this comment.
Everything looks good to me I think
Pin dependencies to fix failing and slow test suite.
matplotlib3.11 produces different images to the baseline. Updating the baseline breaks tests for Python 3.10, so pinning this for now.syrupy>= 5.5 slows down running the tests so reverting to a previous version that deosn't cause this issueBoth of these are plaster fixes, longer term solutions are required:
syrupyis likely the large snapshot for the nodestats tests, this should be investigated.