Skip to content

feat: enhance TemplateSelector with custom dropdown and improved acce…#71

Merged
JosueBrenes merged 1 commit intoACTA-Team:developfrom
DanielCotoJ:develop
Mar 5, 2026
Merged

feat: enhance TemplateSelector with custom dropdown and improved acce…#71
JosueBrenes merged 1 commit intoACTA-Team:developfrom
DanielCotoJ:develop

Conversation

@DanielCotoJ
Copy link
Contributor

@DanielCotoJ DanielCotoJ commented Mar 5, 2026

Summary by CodeRabbit

  • New Features

    • Redesigned template selector with an interactive dropdown interface separating Built-in and Custom templates into distinct sections.
    • Added helpful messaging when no templates are available.
  • Improvements

    • Enhanced keyboard navigation with Escape key support to close the dropdown.
    • Improved visual feedback highlighting the selected template.
    • Better styled dropdown panel with improved layout and scrolling.

@vercel
Copy link
Contributor

vercel bot commented Mar 5, 2026

@DanielCotoJ is attempting to deploy a commit to the ACTA Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Replaced native HTML select element with a custom interactive dropdown component for template selection. The dropdown features state management (open/close), event handling (click-outside, Escape key), accessibility attributes, and organizes templates into Built-in and Custom sections with enhanced styling and fallback messaging.

Changes

Cohort / File(s) Summary
Template Selector Dropdown Refactor
src/components/modules/issue/ui/TemplateSelector.tsx
Replaced native select with custom interactive dropdown, adding open/close state management, outside-click and Escape key handling, and two-section categorization. Introduced memoized template selections (selectedTemplate, builtInTemplates, customTemplates), accessibility attributes (aria-haspopup, aria-expanded, role, aria-selected), and fallback messaging for empty template arrays.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Hops with delight

A dropdown so grand, no native select here,
Templates bloom in sections both far and so near,
Click, choose, and escape—the component takes flight,
Custom and built-in, accessibility tight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: enhancing TemplateSelector with a custom dropdown and improved accessibility features, which directly aligns with the file-level changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link
Contributor

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp Ready Ready Preview, Comment Mar 5, 2026 4:28am

Request Review

@JosueBrenes JosueBrenes merged commit 7585732 into ACTA-Team:develop Mar 5, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants