-
Notifications
You must be signed in to change notification settings - Fork 414
Add french locales #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add french locales #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the i18next framework. Resolves #5
Progress of adaptation: - [x] Questions - [x] Quiz - [ ] Index - [ ] Instructions - [ ] Results
Progress of adaptation: - [x] Questions - [x] Quiz - [x] Index - [x] Instructions - [ ] Results
Progress of adaptation: - [x] Questions - [x] Quiz - [x] Index - [x] Instructions - [x] Results
In order to load the namespaces and do the string binding, just load the i18n.js file on the HTML and call the i18n_load_ns with the namespaces notation found [here](http://i18next.com/translate/namespace/). To fill the string data (e.g. "12 apples), the element must adhere to the following notation (see HTML data-* attributes): ```html <p data-i18n="apple_count" data-amount="18"></p> ``` ```json { "apple_count": "{{amount}} apples" } ``` To refresh the string, alter the data-* attribute accordingly and call `i18n_ready()`.
…lation Corrections according to the ortographic agreement and changes on the master branch
To localize images, add the file-[lng].svg to the value_images/ diretory and add an entry on the corresponding translation.json: "file.svg": "file-[lng].svg"
This reverts commit 144b16c.
Added comments to `i18n.js` on how to block unfinished translations from being published
This reverts commit f7fe42b.
Translation of the remaining questions
Spanish translation, thanks to @locoluis
Rebasing to proper branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #123.
Resolves #61.
Resolves #39.
Resolves #5.
I'll undraft this PR once #123 is merged