Closed
Conversation
Karrenbelt
commented
Oct 1, 2025
| input_=input_path, | ||
| input_file_type=InputFileType.OpenAPI, | ||
| output=output_path, | ||
| output_model_type=DataModelType.DataclassesDataclass, |
Collaborator
Author
There was a problem hiding this comment.
for performance, pydantic was obviously the worst, but there are also DataModelType.TypedDict and DataModelType.MsgspecStruct we could opt for.
TypedDictlikely offers best performance, as it offers purely static type checking and hence no runtime overheadMsgspecStructmay be faster and smaller as they claim, I don't know. I have testedorjson, which offers significant improvement in my websocket brenchmarks (code not in this PR)
Owner
|
Merged with this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.