feat: implemented logic for transfer_position & transfer_positions #79
Merged
8ball030 merged 15 commits into8ball030:mainfrom Sep 11, 2025
Merged
feat: implemented logic for transfer_position & transfer_positions #798ball030 merged 15 commits into8ball030:mainfrom
8ball030 merged 15 commits into8ball030:mainfrom
Conversation
Contributor
Aviksaikat
commented
Aug 22, 2025
Aviksaikat
commented
- feat: implemented logic for transfer_position & transfer_positions in endpoints.py
- feat: added private endpoints in base_client.py
- chore: bumped derive-action-signing version to latest 0.0.13
8ball030
requested changes
Aug 25, 2025
Karrenbelt
reviewed
Aug 25, 2025
8ball030
reviewed
Aug 26, 2025
feat: implemented logic for transfer_position & transfer_positions in endpoints.py chore: bumped derive-action-signing version to latest 0.0.13
Aviksaikat
force-pushed
the
feat/transfer_position/s
branch
from
2e2b523 to
40cd3cf
Compare
…and fix position amount issues - Modified position_setup fixture to fetch instruments dynamically using the API instead of hardcoding - Fixed position amount being 0 by using proper order pricing that ensures fills - Added proper price formatting to meet API requirements (1 decimal place) - Added comprehensive debugging information to help troubleshoot issues - Created test_position_setup.py to verify the fixture works correctly
Karrenbelt
reviewed
Aug 28, 2025
Karrenbelt
reviewed
Aug 28, 2025
Karrenbelt
reviewed
Aug 28, 2025
Karrenbelt
reviewed
Aug 28, 2025
8ball030
requested changes
Aug 28, 2025
Contributor
Author
|
hey @8ball030 @Karrenbelt, this was a first draft. I have already fixed some of the issues. Forgot to push the latest. Will do as soon as the tests pass. Sorry for the confusion |
Owner
|
No worries :) |
…asnfer back to the original account then close it
…e using only the ETH-Perps & transfer_positions was using TRADE_MODULE instead of RFQ
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.