feat(simulation): read-only Conversation view for completed runs#693
Open
alreadyhavefeel wants to merge 1 commit into
Open
feat(simulation): read-only Conversation view for completed runs#693alreadyhavefeel wants to merge 1 commit into
alreadyhavefeel wants to merge 1 commit into
Conversation
Step 3 (Step3Simulation.vue) called doStartSimulation({force:true}) on every
onMounted, so opening a finished simulation force-restarted it — wiping the run
and re-spending tokens. There was also no way to revisit a completed run's
timeline from history.
- Step3Simulation: add initSimulation() that checks run-status first. If the
simulation already ran (completed/stopped/running, or has actions), load the
existing timeline read-only (resume polling only if still running) instead of
force-starting. Genuinely fresh simulations start as before.
- HistoryDatabase: add a "Step3 · Conversation" button to the history modal
that routes to the SimulationRun view for the selected simulation.
- locales: add history.step3Button (en/zh) and update replayHint to reflect
that completed runs are now viewable read-only.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Step3Simulation.vuecallsdoStartSimulation({ force: true })unconditionally inonMounted. Opening Step 3 for a simulation that already finished therefore force-restarts it — discarding the completed run and re-spending LLM/graph budget. There is also no entry point to revisit a completed run's conversation timeline from the history list (the history modal only links to Step 1 / Step 2 / Step 4).Changes
initSimulation()runs on mount: it first checksgetRunStatus. If the simulation has already run (completed/stopped/running, ortotal_actions_count > 0), it loads the existing timeline read-only (fetchRunStatusDetail), resuming live polling only when stillrunning. A genuinely fresh simulation starts exactly as before. No more accidental force-restarts.SimulationRunview for the selected simulation, so completed runs are one click away.history.step3Buttonand updatesreplayHint(which previously said Step 3 doesn't support replay) to reflect that completed runs are now viewable read-only.Notes