Skip to content

Conversation

616b2f
Copy link
Owner

@616b2f 616b2f commented Jan 12, 2025

resolve #4

@616b2f 616b2f changed the title Fix/4/build target uri for windows fix(#4): build target uri for windows Jan 12, 2025
@616b2f 616b2f mentioned this pull request Jan 12, 2025
@schinnerld
Copy link

Two unit tests are still failing.

  1. RequestBuildTargetCompile_ForProjectWithErrors_Success (testcase 1)
    "C:\C:\Git..AspNet.Example.sln" can't be loaded
    Fixed in \src\bsp4csharp\Protocol\BuildTargetIdentifier.cs / Ln 13
    => return Uri.ToString().Replace("file://", "").TrimStart('/');
  2. RequestBuildTargetCompile_ForProjectWithErrors_Success (testcase 2)
    does not work under German language Windows
    Fixed in \test\BuildServerProtocolTests.cs / Ln 67
    => [InlineData(TestProject.AspnetWithRestoreErrors, "(>= 998.0.5)", 2)]

@616b2f
Copy link
Owner Author

616b2f commented Jan 13, 2025

@schinnerld could you try again pls

@schinnerld
Copy link

On my Windows system, all unit tests run without errors with these changes.

@616b2f 616b2f merged commit e3858c8 into main Jan 16, 2025
2 checks passed
@616b2f 616b2f deleted the fix/4/build_target_uri_for_windows branch January 16, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file:// vs. file:///
2 participants