Big update#1
Open
myQwil wants to merge 10 commits into60-hz:mainfrom
Open
Conversation
This will be a nightmare to maintain. Better to encourage users to copy/paste the binary for their OS into the src folder.
ffplay now uses Secret Rabbit Code for resampling, making for much smoother speed transitions.
debug symbols don't really need to be added to release builds
5f67148 to
f9950a9
Compare
Otherwise, the speed will switch from very slow to very fast when given a negative value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a fairly large update recently, involving the implementation of the Secret Rabbit Code resampler, which makes for much smoother speed transitions. Rebuilding for Windows and MacOS still needs to be done before the pull request is ready.
A few other changes were also made:
removed pd-lib-builder and added it back as a submodule
removed duplicate abstractions
to copy/paste the binary for their OS into the src folder.