Refactor: Separate weather parameters from ShipParams into WeatherPar… #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
Refactored
ShipParamsto separate weather-related parameters into a newWeatherParamsclass for better code organization and reusability.Changes
WeatherParamsclass inWeatherRoutingTool/ship/weatherparams.pyShipParamsnow usesWeatherParamsinternallyKey Features
✅ 100% Backward Compatible - No breaking changes
✅ All tests pass - 117/127 passing (same as before)
✅ Property delegation - Existing code like
ship_params.wave_heightstill works✅ Cleaner architecture - Weather separated from ship performance data
Benefits
Usage Examples
Old Way (Still Works)