Skip to content

ASE improvements#89

Open
lL1l1 wants to merge 14 commits into4z0t:developfrom
lL1l1:ASE-customization
Open

ASE improvements#89
lL1l1 wants to merge 14 commits into4z0t:developfrom
lL1l1:ASE-customization

Conversation

@lL1l1
Copy link
Copy Markdown
Contributor

@lL1l1 lL1l1 commented Oct 13, 2025

Fixes:

  • Fix hover counting as navy without any navy selected. This bug was making navy > land priority unusable.

Additions:

  • Use categories for assisters for mod compatibility so that modded engi stations/engineers can be used in the new assist filters
  • Add assist filter options to filter engi stations and drones or all engis including stations/drones
  • Add option to only select assisters with the same target: like UI party or the original selection deprioritizer
    • Assister filter now handles new instant shield assist targets (repair -> assist order) unlike old mods.
  • Make double clicking assisters select only assisters. I didn't add it as an option because shift + double click is available to select all units, and because non-shift actions filtering stuff is expected of this mod and the game itself.

Testing

Test units
   CreateUnitAtMouse('ual0301_engineer', 0,    3.73,    1.26, -1.95079)
   CreateUnitAtMouse('urb4207', 0,  -11.44,   -2.26, -0.00000)
   CreateUnitAtMouse('ual0301_rambo', 0,  -17.09,    4.27,  0.00000)
   CreateUnitAtMouse('ual0301_rambo', 0,  -17.70,    2.03,  0.00000)
   CreateUnitAtMouse('xab1401', 0,   -9.44,  -19.26, -0.00000)
   CreateUnitAtMouse('ual0301_rambo', 0,  -18.02,    0.85,  0.00000)
   CreateUnitAtMouse('xsl0307', 0,   -2.04,   -6.22, -3.00175)
   CreateUnitAtMouse('xsl0307', 0,    8.54,   -8.12, -3.00161)
   CreateUnitAtMouse('xsl0307', 0,    6.75,   -7.55,  3.01809)
   CreateUnitAtMouse('xsl0307', 0,    2.49,   -0.52, -3.00117)
   CreateUnitAtMouse('xsl0307', 0,   -0.29,  -15.01, -2.62670)
   CreateUnitAtMouse('xsl0307', 0,    9.45,  -13.07,  2.58927)
   CreateUnitAtMouse('ual0301_rambo', 0,  -19.44,   -0.26, -0.00000)
   CreateUnitAtMouse('ual0301_engineer', 0,    9.66,    6.74,  1.01063)
   CreateUnitAtMouse('ual0301_engineer', 0,   14.45,   -4.67,  3.03789)
   CreateUnitAtMouse('ual0301_engineer', 0,    2.97,   -4.85, -3.00121)
   CreateUnitAtMouse('xrb0304', 0,   -2.44,    5.74,  0.00000)
   CreateUnitAtMouse('xrb0304', 0,   -2.44,   15.74,  0.00000)
   CreateUnitAtMouse('xrb0304', 0,   -2.44,   13.74,  0.00000)
   CreateUnitAtMouse('xrb0304', 0,   -2.44,    9.74,  0.00000)
   CreateUnitAtMouse('ual0301_engineer', 0,   11.66,    4.70,  0.90025)
   CreateUnitAtMouse('xrb0304', 0,   -2.44,    7.74,  0.00000)
   CreateUnitAtMouse('ual0301_engineer', 0,   11.87,   -5.78,  2.95476)
   CreateUnitAtMouse('ual0301_engineer', 0,   -5.23,    2.05, -1.49252)
   CreateUnitAtMouse('xsl0001', 0,   11.47,    7.07,  0.78058)
   CreateUnitAtMouse('ual0301_engineer', 0,    8.91,   -5.88,  3.01764)
   CreateUnitAtMouse('ual0301_engineer', 0,    9.68,    4.81,  1.20473)
   CreateUnitAtMouse('ual0301_engineer', 0,    5.95,   -5.81, -3.06409)
   CreateUnitAtMouse('ual0301_engineer', 0,   -2.32,    1.13, -1.82949)
   CreateUnitAtMouse('xrb0304', 0,   -2.44,   11.74,  0.00000)

Preview of new options in menu:
{D5396AE9-3135-4A6A-911D-B6B914CE0DFE}
{5BD0DDF1-A69B-430E-AE70-482EB67A596C}

lL1l1 added 11 commits October 12, 2025 16:06
mod compatibility
ex: navy > land domain order caused hover > land even if no navy was selected
Caused several bugs:
- domain filter broken because only assisters were always returned, affecting the selection param for the domain function.
- Assister filter not deselecting assisting units if all possible assisters are assisting
- Assister filter only selecting non-assisting assisting units if there is a mix of assisting/not assisting possible assister units
Comment thread mods/ASE/modules/Selection.lua Outdated
@4z0t
Copy link
Copy Markdown
Owner

4z0t commented Nov 20, 2025

To be honest it feels really bloated already. I'm going to split all of it into 4 diffetent mods:

  • assisters
  • locked
  • layers
  • exotic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants