ASE improvements#89
Open
lL1l1 wants to merge 14 commits into4z0t:developfrom
Open
Conversation
mod compatibility
ex: navy > land domain order caused hover > land even if no navy was selected
This reverts commit 46aef76.
Caused several bugs: - domain filter broken because only assisters were always returned, affecting the selection param for the domain function. - Assister filter not deselecting assisting units if all possible assisters are assisting - Assister filter only selecting non-assisting assisting units if there is a mix of assisting/not assisting possible assister units
b79b184 to
ed1c675
Compare
4z0t
requested changes
Nov 20, 2025
Owner
|
To be honest it feels really bloated already. I'm going to split all of it into 4 diffetent mods:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Additions:
Testing
Test units
Preview of new options in menu:

