Wrapped getUnit8() in a try...catch#11
Open
wyqydsyq wants to merge 1 commit into43081j:masterfrom
wyqydsyq:patch-1
Open
Wrapped getUnit8() in a try...catch#11wyqydsyq wants to merge 1 commit into43081j:masterfrom wyqydsyq:patch-1
wyqydsyq wants to merge 1 commit into43081j:masterfrom
wyqydsyq:patch-1
Conversation
|
I've had the best results by wrapping the entire call to ID3Frame.parse in an exception handler, as there seem to be a handful of assumptions in there that don't hold for all files I've encountered. You can ignore frames that fail to parse and still process the rest of the file. |
|
I came here to propose the exact same change. Catching the exception here avoids unnecessarily failing the whole process due to one small problem in the tag. I agree that there may ultimately be a better place or additional places to put such a change, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping this
ifclause in atry...catchseems to alleviate the issue found in #10 and possibly #9There seems to be no real negative impact in simply ignoring any exceptions generated by the tried code, the resulting
tagsseems to be completely fine, though a more graceful method of handling the exception should probably be implemented.