Skip to content

Conversation

@seyeon22222
Copy link
Contributor

๐Ÿ“Œ ๊ฐœ์š”

  • admin/calendar/list/detail_classification API ๋ฐ˜ํ™˜ ์ˆœ์„œ ์—ญ์ˆœ์œผ๋กœ ์ˆ˜์ •

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • JPA ์ฟผ๋ฆฌ๋ฌธ ์ˆ˜์ •(findAllByClassification -> findAllByClassificationOrderByIdDesc)

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (4cebacd) to head (c12e705).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ar/api/user/utils/service/ScheduleNotiService.java 0.00% 3 Missing โš ๏ธ
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1196      +/-   ##
============================================
+ Coverage     77.66%   77.72%   +0.06%     
  Complexity     1805     1805              
============================================
  Files           590      590              
  Lines          8408     8400       -8     
  Branches        542      540       -2     
============================================
- Hits           6530     6529       -1     
+ Misses         1629     1621       -8     
- Partials        249      250       +1     
Flag Coverage ฮ”
integrationTest 73.64% <40.00%> (+0.04%) โฌ†๏ธ
unitTest 29.42% <0.00%> (+0.02%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

taehyeon3
taehyeon3 previously approved these changes Mar 31, 2025
Copy link
Contributor

@taehyeon3 taehyeon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wonies wonies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ใ…ใ…ใ…

Copy link
Contributor

@taehyeon3 taehyeon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonies wonies merged commit 6273575 into dev Apr 17, 2025
4 of 5 checks passed
@wonies wonies deleted the 1195-refactoring-admincalendarlistdetail_classification-api-๋ฐ˜ํ™˜-์ˆœ์„œ-์—ญ์ˆœ์œผ๋กœ-์กฐ์ • branch April 17, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

๐Ÿ”จ [Refactoring] admin/calendar/list/detail_classification API ๋ฐ˜ํ™˜ ์ˆœ์„œ ์—ญ์ˆœ์œผ๋กœ ์กฐ์ •

4 participants