Fix/staticmethod callable python 3 10 #2263#2466
Open
leonor-p wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ManimGL fails to import on Python < 3.10 with TypeError: 'staticmethod' object is not callable.
Multiple functions across the codebase are declared with @staticmethod
and then used as decorators on other methods inside the same class body.
Prior to Python 3.10, staticmethod objects were not callable, making
this pattern invalid.
Fixes #2263
Proposed changes
Test
Code:
python -c "from manimlib import *"Result: Import completes successfully on Python 3.9.25 with no TypeError.
The ffmpeg RuntimeWarning is expected and unrelated to this fix.
Before:

After:
