Fix missing export Fields type for Icon

[ryanlua]

Fixes the Icon type, which is missing properties and events such as isEnabled and selected.

Reproduction:

icon.toggled:Connect(function()
	print("Toggled")
end)

Closes #214

Before

After

[Copilot]

Pull request overview

Updates the public Luau type surface for Icon so that instance properties/events (e.g. isEnabled, selected, toggled) are available to typed consumers.

Changes:

• Extend export type Icon to include Fields (properties + signals) in its intersection type.

Comments suppressed due to low confidence (1)

src/Types.lua:464

• Methods is already defined as an intersection with StaticFunctions (type Methods = {...} & StaticFunctions), so export type Icon = Methods & Fields & StaticFunctions redundantly intersects StaticFunctions twice. Consider removing the extra & StaticFunctions here (or removing it from Methods) to keep the type composition easier to understand.

export type Icon = Methods & Fields & StaticFunctions --typeof(setmetatable({} :: Fields, MT))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Now that Icon includes Fields, the event/property types in Fields become part of the public API. Several Signal generics in Fields don’t match how the library fires these events at runtime (e.g. toggled is fired with (boolean, fromSource, sourceIcon); selected/deselected are fired with (fromSource, sourceIcon); viewingStarted/viewingEnded are fired with a boolean; notified is fired with a noticeId). Please update the Fields signal type parameters to reflect the actual :Fire(...) signatures so typed consumers can receive the correct arguments.

[ryanlua]

Side note, but this PR is a bit iffy since I don't know well how the types work for TopbarPlus and whether they are 100% correct to begin with. This PR assumes the types are 100% correct to begin with.