LG-16085 Remove legacy same_address_as_id state ID form param compatibility shim - #13359
Open
ameter wants to merge 1 commit into
Open
LG-16085 Remove legacy same_address_as_id state ID form param compatibility shim#13359ameter wants to merge 1 commit into
ameter wants to merge 1 commit into
Conversation
ameter
changed the base branch from
main
to
ameter/lg-16085-same-address-as-id-refactor-3
August 12, 2026 19:43
ameter
marked this pull request as ready for review
August 12, 2026 20:22
ameter
force-pushed
the
ameter/lg-16085-same-address-as-id-refactor-4
branch
from
August 12, 2026 20:23
95f74c4 to
5ac3782
Compare
Base automatically changed from
ameter/lg-16085-same-address-as-id-refactor-3
to
main
August 13, 2026 15:08
…bility shim changelog: Internal, In-person proofing, Remove the legacy same-address form parameter compatibility shim
ameter
force-pushed
the
ameter/lg-16085-same-address-as-id-refactor-4
branch
from
August 13, 2026 15:08
5ac3782 to
eb444ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-16085
DO NOT MERGE! Must not deploy until #13347 has shipped.
🛠 Summary of changes
Final cleanup of the
same_address_as_id->ipp_current_address_matches_idstate ID form parameter rename. The previous PR switched the rendered form to submit the new param name while the server kept accepting both names for 50/50 deploy safety. Now that the form no longer submits the legacy name, the server no longer needs to accept it.state_id_form.rb: removedLEGACY_PARAM_ALIASESand its use inconsume_params.state_id_controller.rb: removed the legacy key from theflow_paramspermit list and thebuild_pending_piilegacy fallback.📜 Testing Plan