Did canTakeItemAmounts In A Smart Way#20
Open
CelestialHoney wants to merge 3 commits into123ishaTest:masterfrom
Open
Did canTakeItemAmounts In A Smart Way#20CelestialHoney wants to merge 3 commits into123ishaTest:masterfrom
CelestialHoney wants to merge 3 commits into123ishaTest:masterfrom
Conversation
…ncies, and add tests for canTakeItemAmounts
Ishadijcks
requested changes
Feb 17, 2024
| * This method very inefficiently clones the inventory, and simulates adding the items see if they can be taken. | ||
| * It's also the only reason we're using lodash... | ||
| * TODO do this in a smart way. | ||
| * Returns if the inventory can lose the given amounts of items |
Contributor
There was a problem hiding this comment.
I think you misunderstood this (admittedly weirdly-named) method. It checked whether we could add all these items to the inventory without it overflowing
Contributor
Author
There was a problem hiding this comment.
Yeah, that is really badly named.
Contributor
Author
There was a problem hiding this comment.
Actually, it looks like IgtInventory.getSpotsLeftForItem() does that....
Are you sure I didn't get this right the first time?
test('Correct spots left', () => {
// Arrange
const inventory: IgtInventory = new IgtInventory(2);
expect(inventory.getSpotsLeftForItem(item1)).toBe(2 * maxExampleStack);
// Act
inventory.gainItem(item1, maxExampleStack + 1);
// Assert
expect(inventory.getSpotsLeftForItem(item1)).toBe(maxExampleStack - 1);
expect(inventory.canTakeItem(item1, maxExampleStack - 1)).toBe(true);
expect(inventory.canTakeItem(item1, maxExampleStack)).toBe(false);
});
test('Correct spots left with multiple items', () => {
// Arrange
const inventory: IgtInventory = new IgtInventory(2);
// Act
inventory.gainItem(item1);
inventory.gainItem(item2);
// Assert
expect(inventory.getSpotsLeftForItem(item1)).toBe(maxExampleStack - 1);
expect(inventory.getSpotsLeftForItem(item2)).toBe(maxExampleStack - 1);
});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did canTakeItemAmounts in a smart way, removed
lodash-esfrom dependencies, and add tests for canTakeItemAmounts inIgtInventory.ts