Pull screen search feature #1256
Conversation
kirtangajjar
requested review from
peterwilsoncc
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
I've added some notes inline.
The UI looks good but I'm hitting a bug with the search. Otherwise the notes a minor.
| add_filter( 'amp_dev_mode_element_xpaths', __NAMESPACE__ . '\add_element_xpaths' ); | ||
| add_filter( 'script_loader_tag', __NAMESPACE__ . '\add_dev_mode_to_assets', 10, 2 ); | ||
| add_action( 'wp_ajax_dt_load_connections', __NAMESPACE__ . '\get_connections' ); | ||
| add_action( 'wp_ajax_dt_load_connections_push', __NAMESPACE__ . '\get_connections' ); |
There was a problem hiding this comment.
I'm assuming this is for clarity from wp_ajax_dt_load_connections_pull?
We're probably stuck with the old name to ensure backward compatibility with the third party extensions and between different versions of the plugin. Otherwise we could go through a soft deprecation.
There was a problem hiding this comment.
Thanks for pointing it out. I've added the old method back with soft deprecation. LMK if I did it correctly(this is my first time doing it)
|
@peterwilsoncc I've addressed your feedback. LMK if you find anything else. |
|
These changes look good, thank you. This is looking good, I'm seeing a bug on the pull screen when there are two connections with the same ID (ie an external connection's POST ID matches the network connection's SITE ID). I'm seeing that selecting the external site is showing the internal site in the drop down following a refresh:
In the gif you'll see I am selecting |
github-actions
bot
added
the
needs:refresh
|
@kirtangajjar thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch? |
3 participants
Description of the Change
Add ability to search for a site on the Pull Content screen
Closes #1235
How to test the Change
Changelog Entry
Credits
Props @kirtangajjar
Checklist: