Fix : fixed the video not appearing bug in first tab #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
quick fix : the remoteVideoStream was not getting rendered again so just a condition check for remoteVideoStream will solve the problems |
Author
|
@hkirat After the condition check for remoteVideoStream && is used to check if remoteVideoStream has a value before rendering the corresponding Video component. This will ensures that the remote video is only displayed if there is a valid remoteVideoStream and if remoteVideoStream is null or undefined, the item will not be rendered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is regarding the bug we are getting when two user is connecting through video chat on the one screen the other's person video is not appearing.