fix: broaden unsigned comparison rule and avoid cast false positives#17
Open
9iang22 wants to merge 1 commit into0xdea:mainfrom
Open
fix: broaden unsigned comparison rule and avoid cast false positives#179iang22 wants to merge 1 commit into0xdea:mainfrom
9iang22 wants to merge 1 commit into0xdea:mainfrom
Conversation
Generalize raptor-incorrect-unsigned-comparison to catch additional unsigned types while excluding signed-cast comparisons. Add mixed and casted test cases to validate the new matching behavior.
Owner
|
Thank you for the PR. Let me think some more about this one. |
Contributor
Author
|
The current version also not support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch additional unsigned types (uint*_t) while excluding signed-cast comparisons
We will cast an unsigned int to a signed one and then compare it with zero to see if there is overflow, but Semgrep can not detect the type cast with typed metavariable.
The following code raises an FP in the original rule with the pattern like
(size_t $E) >= 0.PS: It seems like a bug in the Semgrep engine, but whatever, I set a whitelist pattern here to avoid such FP.